Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding max and min health percent for ECS deployments (no LB services… #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding max and min health percent for ECS deployments (no LB services… #11

wants to merge 1 commit into from

Conversation

adenot
Copy link
Contributor

@adenot adenot commented Jul 2, 2018

… for now)

@adenot adenot requested a review from aarongorka July 2, 2018 07:07
@adenot
Copy link
Contributor Author

adenot commented Jul 2, 2018

@aarongorka do you reckon we should put this as a configurable var at ecs-config.yml? Any use case for LB services?

aarongorka
aarongorka approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@aarongorka aarongorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so this finally gets off my list of PRs that need reviews 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongorka aarongorka aarongorka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adenot @aarongorka